-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copyright: Update to 2023 #8698
Conversation
7746899
to
0b5b42b
Compare
Good job! |
The following is not, and should not be construed as, legal advice, but I really do not understand the rationale for "change all copyright headers" PRs. At best, such bulk changes seem counterproductive, as the final year in the range of every header now reflects simply the current year (a fact totally divorced from the contents of the file), rather than the last year of significant modification (a fact related to the file itself, which, though possibly available via source code control, also reflects some author's judgment as to the materiality of a change). I also note that well-known open source projects, such as the Linux kernel (see, e.g., https://github.com/torvalds/linux/blob/master/kernel/cgroup/cgroup.c) do not follow this practice, and large companies, such as Google, also do not recommend this practice in their open source guidelines (https://opensource.google/documentation/reference/copyright). Surely polluting the repo history and spending time reviewing a change or tool for presumably legal reasons requires some affirmative legal justification, so, I ask: Has anyone received actual legal advice that such changes are productive? Or has this practice been proposed simply because others do it? Notwithstanding the foregoing concerns, I suspect a "change all headers" tool could probably be repurposed to a "check for copyright year edits when editing a file, and warn if absent" tool, which seems maybe helpful to reviewers and contributors. |
@iamamyth I would tend to agree with you. I do it because of this:
and because I saw various contributors doing the same thing at the same time, each having their own sets of updated files, undeniably increasing the review effort, so I thought to have at least just one set, while they can focus on other stuff. |
7871a05
to
49d1c88
Compare
Co-authored-by: plowsof <[email protected]> extra files
49d1c88
to
5b4fea7
Compare
Disclaimer for selsta:
No hidden dev fee was added to this PR.